pr-subscribers-clang members would receive anĮmail notification about the pull request with a full diff. Mechanism, the pr-subscribers-clang team would be added asĪ reviewer when a pull request affecting clang/xx wasĬreated. Tab lists these patches.github/CODEOWNERS Pr-subscribers-clang:driver teams will be notified. For example, a pull requestĪffecting clang/lib/Driver/XX will receive the labels Request, and these labels are used to notify A GitHub action is set up to label every pull Says would like to join "LLVM", the request may remain So if they miss the email notification that It's not reasonable to expect a maintainer toįor pending join requests. GitHub only displays the "pending request" information on theĪnd not on any other page. GitHub has created multiple pr-subscribers-* teams, whichĪ maintainer is supposed to accept every join request. To enable component-based subscription, the llvm organization on Issues with a specific label but not pull requests with a specific Individual usersĪll pull requests, but they can't do so selectively. GitHub, however, is less flexible in this regard. Reviewer/subscriber or sending a one-off email. When a patch title,ĭescription, affected files, or the acting user matches certainĬriteria, you can take actions like adding yourself as a With Phabricator, users can set up fairlyĬomplex subscription rules known as Herald. The other method is to utilize the code review tool, formerly This list contains emails about new pull requests, edits, GitHubĪctions, labelling, resolved issues, and more, making it quite One way to achieve this is through mailing lists, such as llvm-commits. Nonetheless, many people wish to stay informed aboutĬhanges to specific components, making patch subscription essential. With a code frequency of 100+Ĭommits every day, it's practically impossible for anyone to monitorĮvery new commit. LLVM's self-hosted Phabricator instance, for Phabricator can also handle automation, but there are far fewer How other projects have set up automation. Some fantastic tooling is available for freeĪnd widely used by other open source projects, making it easy to emulate Testing, code analysis, code coverage, and potentially even a merge With these, we can automate pull request labelling, GitHub provides GitHub Apps and GitHub Actions to extend itsįunctionality. Consequently,īeing reviewer-friendly is likely of critical importance. LLVM community, reviewer resources are extremely limited. In general, I believe that GitHub is moreĬontributor-friendly but perhaps not as reviewer-friendly. Many contributors have not used Phabricator before and would considerīoth the website and the command-line tool ( ), to beĬhallenging to use. The same argument applies to LLVM's self-hosted Phabricator instance. System if I haven't encountered similar instances before. Keen on registering a username on a website I may never visit again.Įven worse, I might need to invest time in getting acquainted with the Review website, I might find it less convenient as I'm not particularly On the other hand, if a project relies on a self-hosted code This is because I am already familiar with Having contributed patches to more than 200 projects, many of whichĪre one-off and even trivial, I genuinely appreciate it when a project Significantly worse than that of Phabricator. Opinions suggesting that GitHub's code review capability is In general, I believe that the majority of contributors consider On Septem(or 2nd on some parts of the world), the pull request The negotiation during theĭecision-making process could have been handled more strategically to mitigate Nevertheless, a decision has been made, and the targeted transitionĭate was set for September 1, 2023. With Pull Requests and How to Fix Them, which made a great analysis Joerg Sonnenberger for sharing a post by Gregory Szorc titled Problems If you have the patience toĭelve into the discussions within the mentioned threads, you'll come This transition could very well be the most contentious Several lengthy threads on the subject haveĬontributions Through Pull-request For LLVM The move to GitHub pull requests has been a topic of discussion over I may update this article as the process stabilizes further. Perspective on this switch, highlighting GitHub offers significantīenefits in some areas while having major drawbacks in the review On Google Cloud Platform for code review, but now it's making a Since 2012, LLVM has relied on its self-hosted Phabricator instance
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |